Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the FastSim input MinBias for PU samples #22232

Closed
fabiocos opened this issue Feb 15, 2018 · 8 comments
Closed

Fix the FastSim input MinBias for PU samples #22232

fabiocos opened this issue Feb 15, 2018 · 8 comments

Comments

@fabiocos
Copy link
Contributor

The FastSim code migration made before 10_1_0_pre1 build with #20666 is breaking the existing relVal wf with PU because the old MinBias files are incompatible, content-wise, with the new code (different collection name because of different producer name).
10_1_0_pre1 FastSim files should replace the old ones in PyReleaseValidation to prevent crashes.

@cmsbuild
Copy link
Contributor

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

assign pdmv

@cmsbuild
Copy link
Contributor

New categories assigned: pdmv

@fabozzi,@prebello,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fabiocos
Copy link
Contributor Author

Dear PdmV experts, when do you expect we can have the files and the corresponding fix in the IB?

@prebello
Copy link
Contributor

Dear @fabiocos
The requested input
/RelValMinBiasFS_13_ForMixing/CMSSW_10_1_0_pre1-100X_mcRun2_asymptotic_v2_FastSim-v1/GEN-SIM-RECO
is announced.
It will be tested in the latest IB to open PR with FastSim and GENSIM string updates in 10_1_X, all by tomorrow (Friday).

@fabiocos
Copy link
Contributor Author

@prebello excellent, thanks, as soon as tests are fine please post a PR, so as we can have running wfs hopefully by the week-end

@prebello
Copy link
Contributor

Dear @fabiocos please consider to merge #22255 and #22256 together. Thank you

@fabiocos
Copy link
Contributor Author

@prebello they are now both merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants