Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include workflow that uses pre-mixing in PR integration tests #22586

Closed
christopheralanwest opened this issue Mar 12, 2018 · 4 comments
Closed

Comments

@christopheralanwest
Copy link
Contributor

Recently there have been two instances [1, 2] in which pre-mixing release validation has failed for the HCAL because the histograms needed for validation were entirely missing. It seems that this sort of problem could be caught easily in PR integration tests. Would it be possible to include a workflow that uses pre-mixing in the PR integration tests to ensure that such problems are identified prior to the release validation?

Attn: @kpedro88 @deguio @hatakeyamak

[1] https://its.cern.ch/jira/browse/CMSLITDPG-249
[2] https://hypernews.cern.ch/HyperNews/CMS/get/relval/10038/29.html

@cmsbuild
Copy link
Contributor

A new Issue was created by @christopheralanwest .

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

I support the request as it would solve also my immediate need for #22454 (in the context of phase2 premixing development).

@makortel
Copy link
Contributor

I suggest we add a combined stage1+stage2 workflow for 2018 in the PR tests once #22956 (which adds them) gets merged.

@makortel
Copy link
Contributor

Addressed in cms-sw/cms-bot#978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants