Circular inclusion in TrackingTools/GsfTools

[mrodozov]

The last remaining header from the fsyntax check that we couldn't fix is this one:
TrackingTools/GsfTools/interface/MultiGaussianStateCombiner.h
with this short description:

In file included from /build/cmsbld/jenkins/workspace/ib-run-check-headers/CMSSW_10_2_X_2018-06-20-2300/src/TrackingTools/GsfTools/interface/MultiGaussianState.h:112:0,
                 from src/TrackingTools/GsfTools/interface/MultiGaussianStateCombiner.h:4:
/build/cmsbld/jenkins/workspace/ib-run-check-headers/CMSSW_10_2_X_2018-06-20-2300/src/TrackingTools/GsfTools/interface/MultiGaussianState.icc: In member function 'void MultiGaussianState<N>::checkCombinedState() const':
/build/cmsbld/jenkins/workspace/ib-run-check-headers/CMSSW_10_2_X_2018-06-20-2300/src/TrackingTools/GsfTools/interface/MultiGaussianState.icc:52:3: error: 'MultiGaussianStateCombiner' was not declared in this scope
   MultiGaussianStateCombiner<N> theCombiner;
   ^~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-run-check-headers/CMSSW_10_2_X_2018-06-20-2300/src/TrackingTools/GsfTools/interface/MultiGaussianState.icc:52:33: error: 'theCombiner' was not declared in this scope
   MultiGaussianStateCombiner<N> theCombiner;
                                 ^~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-run-check-headers/CMSSW_10_2_X_2018-06-20-2300/src/TrackingTools/GsfTools/interface/MultiGaussianState.icc: In member function 'void MultiGaussianState<N>::setWeight(double)':
/build/cmsbld/jenkins/workspace/ib-run-check-headers/CMSSW_10_2_X_2018-06-20-2300/src/TrackingTools/GsfTools/interface/MultiGaussianState.icc:62:12: error: 'DBL_MIN' was not declared in this scope
   if ( wgt>DBL_MIN )  rescaleWeight(newWeight/wgt);
            ^~~~~~~

Can we ask you to help us with that, as it requires expert with better understanding than us of this package, to avoid the circular inclusions present.
To reproduce the issue

git-cms-addpkg TrackingTools/GsfTools
scram p -j 16 -k check-headers

References to the error:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/check_headers/CMSSW_10_2_X_2018-06-20-2300/slc6_amd64_gcc630/build.log

Thanks in advance,
Cheers,
M.

[cmsbuild]

A new Issue was created by @mrodozov Mircho Rodozov.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

[VinInn]

My only solution would be to combine the two headers in one.

[perrotta]

As far as I can see, this got fixed by #26020 : @Dr15Jones, can you confirm (and close this issue, if so)?

[Dr15Jones]

@perrotta I thought we were just waiting for a reconstruction L2 to do sign off on this issue, then it will be closed.

[Dr15Jones]

@perrotta it does look like the problem was fixed in the referenced pull request.

[perrotta]

+1

• Solved with Cleanups in TrackingTools/GsfTools #26020: thank you @Dr15Jones for the confirmation

[cmsbuild]

This issue is fully signed and ready to be closed.