Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with arbitrary Paths in cff files in cmsDriver/ConfigBuilder? #24193

Closed
makortel opened this issue Aug 3, 2018 · 8 comments
Closed

Comments

@makortel
Copy link
Contributor

makortel commented Aug 3, 2018

One prototype for including accelerator algorithms that we are exploring in patatrack (cms-patatrack#100) would require defining Paths in cff configuration files (see also #24188 and #24190). This approach clashes with the cmsDriver/ConfigBuilder configuration generation. Those insert an explicit cms.Schedule in the final configuration file that then dictates which Paths are run.

If we start to add Paths in intermediate cff configs, we need to somehow communicate the existence of these Paths to ConfigBuilder so that it can add them to the Schedule. (easiest would be to just hardcode them in ConfigBuilder).

Alternative would be to remove the explicit cms.Schedule from the configuration and thus run all Paths that are defined. Obviously this implies rewriting the parts of ConfigBuilder dealing with Schedule (especially for Alca and Skims), and possibly some cleanup/reorganization of some configuration fragments.

In the unscheduled, dependence-driven mindset dropping the explicit Schedule would feel more natural.

@Dr15Jones @wddgit

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2018

A new Issue was created by @makortel Matti Kortelainen.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

assign core

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2018

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fwyzard
Copy link
Contributor

fwyzard commented Aug 16, 2018

I have been writing for a while how to try and support this with the use of a ProcessFragment, when my laptop badly crashed :-(

So, quick summary:

  • if the cff files put their configuration in a ProcessFragment instead of their top level namespace, they can define also a Schedule
  • process.extend should be taught to merge a Schedule instead of replacing it

@makortel
Copy link
Contributor Author

@fwyzard Thanks for the suggestion, I'd like to learn a bit more how it would work with ProcessFragment.

How is ProcessFragment dealt with by process.load('Foo.Foo.foo_cff') if the fragment is defined in the foo_cff (or in a file imported by it)? Does the process get automatically extended by the fragment?

@makortel
Copy link
Contributor Author

makortel commented Dec 6, 2018

Superseded by #25439.

@makortel makortel closed this as completed Dec 6, 2018
@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants