Errors in RPCtoDTTranslator::run

[davidlange6]

Hi

looking briefly at

https://cms-unified.web.cern.ch/cms-unified//joblogs/pdmvserv_task_JME-RunIIAutumn18DRPremix-00006__v1_T_181026_081834_1331/139/JME-RunIIAutumn18DRPremix-00006_0/49bc6499-61f9-4ecb-a98b-ffaa5510f2bb-89-0-logArchive/job/WMTaskSpace/cmsRun1/cmsRun1-stdout.log

its not obvious to me how all of the l1-1, l2-1 are protected against being <0 in:

https://cmssdt.cern.ch/lxr/source/L1Trigger/L1TTwinMux/src/RPCtoDTTranslator.cc?v=CMSSW_10_4_X_2018-11-13-2300

in particular this one

https://cmssdt.cern.ch/lxr/source/L1Trigger/L1TTwinMux/src/RPCtoDTTranslator.cc?v=CMSSW_10_4_X_2018-11-13-2300#0156

as itr2 is not reset to 0 each time the loop starting at

https://cmssdt.cern.ch/lxr/source/L1Trigger/L1TTwinMux/src/RPCtoDTTranslator.cc?v=CMSSW_10_4_X_2018-11-13-2300#0139

is started.(perhaps it should be?)

[cmsbuild]

A new Issue was created by @davidlange6 David Lange.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[davidlange6]

assign l1

[cmsbuild]

New categories assigned: l1

@rekovic,@nsmith-,@thomreis you have been requested to review this Pull request/Issue and eventually sign? Thanks

[fabiocos]

#25275 (where the fix by @Dr15Jones is implemented) has been merged, and backports have been prepared for 10_2_X (#25315) and 10_3_X (#25314)