Memory leak from HepPDT::ParticleDataTable::particle

[Dr15Jones]

valgrind has found the following call to be leaking memory:

cmssw/SimTracker/SiStripDigitizer/plugins/SiLinearChargeDivider.cc

Line 41 in 02d4198

ParticleData const * particle = theParticleDataTable->particle( hit->particleType() );

I traced the leak to line 28 of HeavyIonUnknownID::processUnknownID
http://lcgapp.cern.ch/project/simu/HepPDT/HepPDT.3.03.00/html/HeavyIonUnknownID_8cc-source.html

CMS specifies to use that class here

cmssw/SimGeneral/HepPDTESSource/src/HepPDTESSource.cc

Line 16 in 02d4198

auto pdt = std::make_unique<PDT>( "PDG table" , new HepPDT::HeavyIonUnknownID );

[cmsbuild]

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign simulation, generator

[cmsbuild]

New categories assigned: simulation

@mdhildreth,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

[kpedro88]

assign generators

[cmsbuild]

New categories assigned: generators

@perrozzi,@alberto-sanchez,@qliphy,@efeyazgan you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

A work around is in #25298

I did contact the original author of HepPDT with the problem.

[fabiocos]

@Dr15Jones your fix has been merged in CMSSW_10_4_X_2018-11-25-0000. Until an external update is possible, I assume this is the solution to this issue.

[Dr15Jones]

@fabiocos I assume this is the solution to this issue.

Yes