Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of strtok in CMSSW #25641

Closed
Dr15Jones opened this issue Jan 12, 2019 · 8 comments
Closed

Remove use of strtok in CMSSW #25641

Dr15Jones opened this issue Jan 12, 2019 · 8 comments

Comments

@Dr15Jones
Copy link
Contributor

The C function strtok is thread hostile as it internally holds static memory. It can relatively easily be replaced by calling strtok_r instead.

@Dr15Jones
Copy link
Contributor Author

assign core

@cmsbuild
Copy link
Contributor

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

The following files make use of strtok:
Alignment/Geners/src/BinaryArchiveBase.cc
CalibTracker/SiStripChannelGain/plugins/SiStripGainFromAsciiFile.cc
DQMOffline/CalibTracker/plugins/SiStripQualityHotStripIdentifierRoot.cc
EventFilter/HcalRawToDigi/plugins/HcalLaserEventFilter2012.cc
EventFilter/L1TXRawToDigi/test/testUCTUnpacker.cpp
FWCore/Services/plugins/SimpleMemoryCheck.cc
IORawData/DTCommissioning/plugins/RawFile.cc
PhysicsTools/MVATrainer/plugins/mlp_gen.cc

@fabiocos
Copy link
Contributor

#25642 implementing the replacement for SimpleMemoryChecker has been merged

@Dr15Jones
Copy link
Contributor Author

The following pull requests remove all uses of strtok: #25654 #25655 #25656 #25657 #25658 #25660

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants