Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4Hep DT Geometry Builder: implement comments #25868

Closed
fabiocos opened this issue Feb 6, 2019 · 6 comments
Closed

DD4Hep DT Geometry Builder: implement comments #25868

fabiocos opened this issue Feb 6, 2019 · 6 comments

Comments

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2019

In the review of #25842 a list fo comments was proposed to @ianna by @Dr15Jones and @cvuosalo . We agreed to merge the PR to simplify further work, and address all the comments in a second step. This issue should serve as a reminder for the follow-up.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Feb 6, 2019

assign geometry

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@ianna,@civanch,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

@ianna
Copy link
Contributor

ianna commented Sep 15, 2020

@cvuosalo and @slomeo - please, have a look at the comments in #25897. They have to be addressed. One in particular: using smart pointers.

@ianna
Copy link
Contributor

ianna commented Oct 27, 2020

+1

done

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants