Circular dependency in L1 code (PR 25973) to be solved

[fabiocos]

The PR #25973 looks to introduce a circular dependency between tcdsDigis and rawDataCollector that causes two unit tests to fail in the IB (see e.g. https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc700/www/sun/10.6-sun-00/CMSSW_10_6_X_2019-02-24-0000?utests ). #26003 temporarily reverts it, the addition of the new feature needs a revision to avoid this problem.

[cmsbuild]

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[fabiocos]

assign l1

@apana FYI

[cmsbuild]

New categories assigned: l1

@rekovic you have been requested to review this Pull request/Issue and eventually sign? Thanks

[apana]

Dear @fabiocos,

My apologies for taking so long to get back to this issue. Unfortunately, it's been so long that the log file you pointed me to does not seem to exist anymore, so I don't know what tests failed. Can you send me instructions on how to run the unit tests in the IB so I can find out which of the tests failed.

Sorry for the trouble

[fabiocos]

@apana the failing tests were testTauEmbeddingProducers and testPhase2PixelNtuple , in TauAnalysis/MCEmbeddingTools and SLHCUpgradeSimulations/Geometry respectively. Just restore your update (git revert 4024430f99b712ff83df34abc344c3e483d6a8f6 on top of CMSSW_10_6_X and then recompile Configuration/StandardSequences and L1Trigger/L1TGlobal), and execute the two tests

[abrinke1]

Hi @apana ,
Any progress on this?
Andrew, @rekovic , @davignon

[apana]

Yes. I hoping to put the PR in today.

[apana]

Hi Andrew. The PR that fixes the issues with the circular dependency has been submitted. It's #26378. Apologies for the delay. @abrinke1, @fabiocos, @rekovic, @davignon

[abrinke1]

Thanks, @apana !

[peruzzim]

assign xpog

XPOG believes this is an important feature to add to MINIAOD for UL

[cmsbuild]

New categories assigned: xpog

@peruzzim,@fgolf you have been requested to review this Pull request/Issue and eventually sign? Thanks

[peruzzim]

+xpog

after the revert, I understand this has been properly integrated in #26461

[fabiocos]

this issue seems to have been positively solved