New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] [Simulation] [Validation] G4 Materials validation #28168
Comments
A new Issue was created by @ianna Ianna Osborne. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign geometry,simulation |
New categories assigned: geometry,simulation @Dr15Jones,@cvuosalo,@mdhildreth,@mdhildreth,@ianna,@civanch,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks |
DD4hep: <material name="hcalforwardmaterial_HFAbsorber0x7f52e629b740" state="solid">
<P unit="pascal" value="101324.845390854"/>
<MEE unit="eV" value="207.159300327033"/>
<D unit="g/cm3" value="4797.63625441346"/>
<fraction n="0.996816000004741" ref="CMS_element0x7f52e6848900"/>
<fraction n="1.49880000000713e-06" ref="CMS_element0x7f52ef29ee80"/>
<fraction n="0.00106178410721505" ref="CMS_element0x7f52ef29ed00"/>
<fraction n="2.58000000001227e-08" ref="ARGON0x7f52ef29ef40"/>
<fraction n="0.00010092261923448" ref="HYDROGEN0x7f52ef29ec40"/>
<fraction n="0.000931689692794431" ref="CMS_element0x7f52ef29edc0"/>
<fraction n="0.00108807897601517" ref="CMS_element0x7f52ef29eb80"/>
</material> vs DD: <material name="HFAbsorber0x7f732da01180" state="solid">
<T unit="K" value="293.15"/>
<MEE unit="eV" value="284.911565693922"/>
<D unit="g/cm3" value="7.68665595559477"/>
<fraction n="0.996816" ref="Fe0x7f733249cf00"/>
<fraction n="1.4988e-06" ref="N0x7f733249c780"/>
<fraction n="0.00106178410721" ref="O0x7f733249c840"/>
<fraction n="2.58e-08" ref="Ar0x7f733249c900"/>
<fraction n="0.000100922619234" ref="H0x7f733249c9c0"/>
<fraction n="0.00093168969279" ref="Si0x7f733249d5c0"/>
<fraction n="0.00108807897601" ref="C0x7f733249cfc0"/>
</material> |
@ianna to be clean, we are speaking of what happens in https://cmssdt.cern.ch/lxr/source/SimG4Core/Geometry/src/DDG4Builder.cc#0059 , under our control, vs what happens in https://cmssdt.cern.ch/lxr/source/SimG4Core/Geometry/src/DD4hep_DDG4Builder.cc#0034 inside DD4hep, am I correct? |
Material Validation Summary The analyzers run in CMSSW_11_0_X_2019-11-13-2300 IB.
they should be:
DD4hep Vacuum conversion:
DD definition of Vacuum:
|
The units converter bug is reported to DD4hep team and will be fixed asap. |
@ianna , there are two separate issues: CMS material definition and DD4Hep. Concerning CMS I have in mind to define all elements differently both in DD and DD4Hep cases using G4 database. After that, some part of differences in materials may gone. What will be left is duplicated materials and materials which have different densities and/or compositions in DD and DD4Hep, which should be resolved one by one. Independently you may send a ticket to DD4Hep with all problems we have. |
#28404 fixes atomic weight and density issues. |
@civanch - after testing with normalised after parsing xml values (PR#28404) all but one differences in materials have gone. The only difference I see is the temperature. G4 from DD4hep 273.15 K:
vs
|
@ianna , Great! G4 temperature is more correct, it is 20C and not 0C defined in DD4Hep but this is really very minor problem, we may have work around and additionally notify DD4Hep developers. |
@civanch - yes. It looks like G4 uses NTP: 20 C and 1 atm and ROOT uses STP: 0 C and 1 atm. DD4hep neither manipulate nor define these properties. |
Updated GDML dump of the G4 geometry built with DD4hep defines MEE values close to the DD's. For example, 284.911565734504 eV vs 284.911565693922 eV: <material name="hcalforwardmaterial_HFAbsorber0x7fe222384740" state="solid">
<P unit="pascal" value="101324.845390854"/>
<MEE unit="eV" value="284.911565734504"/>
<D unit="g/cm3" value="7.68666"/>
<fraction n="0.996816000004741" ref="CMS_element0x7fe222ac7900"/>
<fraction n="1.49880000000713e-06" ref="CMS_element0x7fe22ba9ee80"/>
<fraction n="0.00106178410721505" ref="CMS_element0x7fe22ba9ed00"/>
<fraction n="2.58000000001227e-08" ref="ARGON0x7fe22ba9ef40"/>
<fraction n="0.00010092261923448" ref="HYDROGEN0x7fe22ba9ec40"/>
<fraction n="0.000931689692794431" ref="CMS_element0x7fe22ba9edc0"/>
<fraction n="0.00108807897601517" ref="CMS_element0x7fe22ba9eb80"/>
</material> |
@ianna Would you say this issue is resolved? If not, what would you say still needs to be fixed? |
@cvuosalo - as I mentioned here #28168 (comment) DD4hep is moving to G4 units as the default ones. We haven't updated to this version yet. I'd rerun the tests after that to make sure all numbers match, then close this issue. |
@cvuosalo and @civanch - The major differences have been fixed. I suppose, the issue can be closed.
|
+1 |
There seem to be very few discrepancies left in G4 materials.
DDD description:
DD4hep description:
|
Alright, #33257 fixed the issue with pixfwdMaterials:FPix_CFSkin, FPix_CFSkin_InnerInnerRing, Pix_CFSkin_InnerOuterRing, FPix_CFSkin_OuterInnerRing, FPix_CFSkin_OuterOuterRing |
Present status, DDD <-> DD4hep materials:
What shall we do regarding:
If these remaining points can be seen as fine, I guess we can close this issue indeed? |
+1 |
This issue is fully signed and ready to be closed. |
Compare G4 material properties produced with the DD4hep Geant4 converter vs produced with the DD one.
@cvuosalo - just making a traceable note what needs to be done to complete the migration
The text was updated successfully, but these errors were encountered: