New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add local caching interface in MagneticField #28284
Comments
A new Issue was created by @slava77 Slava Krutelyov. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign reconstruction,simulation |
New categories assigned: reconstruction,simulation @mdhildreth,@slava77,@perrotta,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks |
This should be probably closed with #29561 . |
+1 via discussion related to #29561 |
This issue is to address the performance scaling problem resulting from cache trashing of the cache used in the MagGeometry (internal to the VolumeBasedMagneticField) observed in multi-threaded applications.
As a follow up to #28180, in line with #28180 (comment), an update to the interface is expected in 2019 with follow up PR(s) to enable/benefit from local caching.
For convenience, a copy from #28180 (comment)
it will be straightforward to move the internal cache up to MagGeometry::fieldInTesla(const GlobalPoint& gp) and add a separate MagGeometry::fieldInTesla(const GlobalPoint& gp, MagneticFieldCache& cache) since these are very simple methods.
@namapane @amadio @dpiparo
The text was updated successfully, but these errors were encountered: