Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add local caching interface in MagneticField #28284

Closed
slava77 opened this issue Oct 27, 2019 · 7 comments
Closed

add local caching interface in MagneticField #28284

slava77 opened this issue Oct 27, 2019 · 7 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Oct 27, 2019

This issue is to address the performance scaling problem resulting from cache trashing of the cache used in the MagGeometry (internal to the VolumeBasedMagneticField) observed in multi-threaded applications.
As a follow up to #28180, in line with #28180 (comment), an update to the interface is expected in 2019 with follow up PR(s) to enable/benefit from local caching.

For convenience, a copy from #28180 (comment)
it will be straightforward to move the internal cache up to MagGeometry::fieldInTesla(const GlobalPoint& gp) and add a separate MagGeometry::fieldInTesla(const GlobalPoint& gp, MagneticFieldCache& cache) since these are very simple methods.

@namapane @amadio @dpiparo

@cmsbuild
Copy link
Contributor

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Oct 27, 2019

assign reconstruction,simulation

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction,simulation

@mdhildreth,@slava77,@perrotta,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@civanch
Copy link
Contributor

civanch commented Oct 28, 2019

@slava77 , @namapane , @amadio, how will proceed? who will make PR(s)?

@namapane
Copy link
Contributor

namapane commented Oct 28, 2019

@civanch, as I mentioned in #28180 I can add the new interface but I am working on other developments in the same subsystem that I'd prefer to finish beforehand. It will take a couple of weeks I hope. Otherwise it's fine for me if that is done independently by somebody else; just let me know.

@namapane
Copy link
Contributor

This should be probably closed with #29561 .

@slava77
Copy link
Contributor Author

slava77 commented May 18, 2020

+1

via discussion related to #29561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants