Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non reproducibility of LETDCTime HCAL DigiTask histograms in PR tests #28367

Closed
fabiocos opened this issue Nov 8, 2019 · 9 comments
Closed

Comments

@fabiocos
Copy link
Contributor

fabiocos commented Nov 8, 2019

After the integration of #28330 we observe non reproducibility of DQM histograms in the LETDCTime section of HCAL DigiTask tests, in PRs which cannot affect this (e.g. #28363).
This happens for test wfs 10024.0, 10042.0 and 10224.0 .

This issue is to keep track of the problem (whose origin seems defined) after the initial remarks by @abdoulline #28330 (comment) until it is solved.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2019

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 8, 2019

assign reconstruction,simulation,dqm

@abdoulline @lwang046 @DryRun FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2019

New categories assigned: dqm,reconstruction,simulation

@mdhildreth,@jfernan2,@slava77,@andrius-k,@schneiml,@fioriNTU,@perrotta,@kmaeshima,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@abdoulline
Copy link

abdoulline commented Nov 8, 2019

We've agreed with Long on a workaround and he's just submitted it:
#28368

In the meantime, I've asked our DQM expert (David @DryRun) to try to figure out what might have been a reason of this issue, specific to 2017 HEP17 (QIE11 pilot module) in legacy HE (QIE8).

Even if we know and all agreed earlier this year that HCAL DQM (prompt-reco data-oriented, now fully turned=updated toward Run3) back-compatibility is not required, e.g. see here: #27149
it's not clear to me how it can be a reason for non-reproducibility of MC HEP17 TDC results in this particular 2017 MC case...

@slava77
Copy link
Contributor

slava77 commented Nov 13, 2019

it looks like this can be signed and closed.
@perrotta please confirm (since you followed up on this directly).

@perrotta
Copy link
Contributor

it looks like this can be signed and closed.
@perrotta please confirm (since you followed up on this directly).

According to what @abdoulline wrote in #28368 (comment) , there can be still an issue with the HCAL data-specialized DQM (DQM/HcalTasks: DigiTask, where the issue popped up). That specialized DQM is not even supposed to be used for 2018 data, and of course not for MC and previous years.

As such this is certainly not an issue for reco any more, and as far as I understand not even for DQM.

@perrotta
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor Author

@slava77 @perrotta in practice the issue has not been observed after the integration of the workaround, so I believe that this can be closed at this point, @jfernan2 do you agree?

@jfernan2
Copy link
Contributor

+1
Yes, it seems this is gone. Nevertheless, we expect some DQM cleanup from HCAL in the mid-term future. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants