Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate changing MessageDrop::runEvent to std::string_view #28451

Closed
Dr15Jones opened this issue Nov 21, 2019 · 7 comments
Closed

Investigate changing MessageDrop::runEvent to std::string_view #28451

Dr15Jones opened this issue Nov 21, 2019 · 7 comments
Labels
core-approved fully-signed

Comments

@Dr15Jones
Copy link
Contributor

With the change #28450 it looks like all the string copies done to fill MessageDrop::runEvent are now redundant as the source string has a lifetime as long as that value of runEvent is in use.
@Dr15Jones
Copy link
Contributor Author

assign core

@cmsbuild
Copy link
Contributor

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

See #28457 for a solution

@fabiocos
Copy link
Contributor

@Dr15Jones your #28457 has been now integrated

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core-approved fully-signed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dr15Jones @fabiocos @cmsbuild