[DD4Hep] Unit test fails because of NULL values in XML

[mrodozov]

The latest integration test cms-sw/cmsdist#5554 of DD4Hep fails because of failing to parse the NULL values in this section:
https://github.com/cms-sw/cmssw/blob/master/Geometry/TrackerCommonData/data/tibstring0ll.xml#L71
seems to be line
https://github.com/cms-sw/cmssw/blob/master/Geometry/TrackerCommonData/data/tibstring0ll.xml#L79

Detector         INFO  *********** Created World volume with size: 10100 10100 45000
DD4CMS           ERROR Exception while processing xml source:file:///data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-02-16-2300/src/Geometry/TrackerCommonData/data/tibstring0ll.xml
DD4CMS           ERROR ----> The type std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > cannot be converted: Data conversion of [tibstringpar:NULL,tibstringpar:NULL,tibstringpar:NULL] to type 'std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >' is not defined.
dd4hep: Error interpreting XML nodes of type <Algorithm/>
E

Both test fail for the same reason , fail to parse that part, see https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60f4e6/4695/unitTests.log

Please suggest what to do / provide a fix.

[cmsbuild]

A new Issue was created by @mrodozov Mircho Rodozov.

@Dr15Jones, @smuzaffar, @silviodonato, @makortel, @davidlange6, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign geometry

[cmsbuild]

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cvuosalo]

The unit test runs fine in CMSSW_11_1_X_2020-02-17-1100

[cvuosalo]

@mrodozov Could you please clarify what previous version of DD4hep were we using? And what version of DD4hep is failing this unit test?

[mrodozov]

The unit test is failing in the integration test for the update of DD4hep external, they are not failing in the current IB.
The versions can be seen here:
https://github.com/cms-sw/cmsdist/pull/5554/files , the one we are using currently is:
AIDASoft/DD4hep@5bbbb8c
and the one we one to update to is
AIDASoft/DD4hep@e788246
To setup the new version and run it to fail do this:

ssh cmsdev21 ; mkdir -p /build/${USER} ; cd /build/${USER} 
git clone https://github.com/cms-sw/cms-bot
 ./cms-bot/test-prs.sh cms-sw/cmsdist#5554
# when the pull request is built go in the checked CMSSW area and checkout 
git-cms-addpkg DetectorDescription/DDCMS
scram b -j 16
scram b runtests

to make the unit tests fail

[cvuosalo]

Issue opened with DD4hep: AIDASoft/DD4hep#628

[cvuosalo]

This problem is fixed with the new version of DD4hep. See cms-sw/cmsdist#5554

[cvuosalo]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.