-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferred way to break DataFormats/TrackReco and DataFormats/TrackCandidate circle? #31301
Comments
A new Issue was created by @davidlange6 David Lange. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign reconstruction |
@davidlange6 |
after looking a bit more, I see that the direct dependence of TrackReco on TrackCandidate is only in the dictionaries definition in classes.h used for an aggregate The dependence of TrackCandidate is apparently via @davidlange6 |
Yes, that sentence misses a question mark. Would we like DataFormats/TrackReco to depend on DataFormats/TrackCandidate or would we like DataFormats/TrackCandidate to depend on DataFormats/TrackReco?
On Aug 31, 2020, at 2:50 PM, Slava Krutelyov <notifications@github.com<mailto:notifications@github.com>> wrote:
@davidlange6<https://github.com/davidlange6>
I'm missing details or being confused by the phrasing (perhaps as trivial as a question mark in the "Which package is meant to depend on the other.")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31301 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ3KHEN7YROFOTROORDSDOL7VANCNFSM4QQPAVCA>.
|
Yes, thats all correct.
On Aug 31, 2020, at 3:01 PM, Slava Krutelyov <notifications@github.com<mailto:notifications@github.com>> wrote:
after looking a bit more, I see that the direct dependence of TrackReco on TrackCandidate is only in the dictionaries definition in classes.h used for an aggregate <TrackCandidate, Track> definition.
The dependence of TrackCandidate is apparently via
DataFormats/TrackCandidate/interface/TrackCandidate.h:
#include "DataFormats/TrackReco/interface/TrajectoryStopReasons.h"
@davidlange6<https://github.com/davidlange6>
please clarify if this is what you meant with the issue description.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31301 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ6NHONULXTSIOFILADSDONLZANCNFSM4QQPAVCA>.
|
From a quick look, I tend to agree on that. That would also imply to move the corresponding *cc. |
FWIW, TrajectoryStopReasons is actually a track candidate stop reason. |
+1 fixed in #31327 (merged Sept 3) |
This issue is fully signed and ready to be closed. |
There is a ~trivially fixed circular dependency between DataFormats/TrackReco and DataFormats/TrackCandidate. Which package is meant to depend on the other. I can move things accordingly (either some dictionaries that use classes from both packages or one header)
The text was updated successfully, but these errors were encountered: