Check usage of multi5x5 ECAL modules, and remove them from the reco sequences when not needed

[perrotta]

During the review of #31332 a misconfiguration of one of the multi5x5SuperClusters modules was found (and fixed).
This was supposed not to be too harmful, not only because the effect on the produced objects of such a misconfiguration are expected to be minor, but also because that multi5x5 wasn't supposed to be run in normal pp workflows, only in some HI one.

In reality, while looking at the reconstruction output it is evident that those objects are also produced and saved in (at least) a few pp workflows. Being them kept in the RecoEcal EventContent (as well as in some PF Display one, which is however only used in a few test scripts) probably originates their producers being run also in the pp sequences.

ECAL and EGM should check together (perhaps with the advice of the PF group) were those modules actually need to be run, and remove them from the reco sequences when not needed

@rchatter
@afiqaize @SohamBhattacharya
@hatakeyamak @bendavid

[cmsbuild]

A new Issue was created by @perrotta .

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[perrotta]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

[jpata]

type ecal

[jpata]

@thomreis @cms-sw/ecal-dpg-l2 it looks like the multi5x5 is still being run for Run3, but as I understand from the description above, should not be run. Can you please look into it?

[thomreis]

I quickly checked and just removing the modules from the eventContent does not seem to be sufficient, at least for WF 139.001. Some other module must still consume the collections.

[makortel]

You can get a dump of the consumes information e.g. by adding process.add_(cms.Service("Tracer", dumpPathsAndConsumes=cms.untracked.bool(True))) to the configuration. Note that the Tracer service will print lots of other information as well.

[thomreis]

You can get a dump of the consumes information e.g. by adding process.add_(cms.Service("Tracer", dumpPathsAndConsumes=cms.untracked.bool(True))) to the configuration. Note that the Tracer service will print lots of other information as well.

That's great. I was wondering yesterday if such a feature exists.

[thomreis]

Looking at the RECO step of 11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+RecoNano+HARVESTNano+ALCA I can see that for example photons runs in the reconstruction_step in the schedule and consumes photonCore, which consumes correctedMulti5x5SuperClustersWithPreshower, which consumes multi5x5SuperClustersWithPreshower, which consumes multi5x5SuperClustersWithPreshower, which consumes multi5x5BasicClustersCleaned, multi5x5SuperClustersCleaned, multi5x5BasicClustersUncleaned, and multi5x5SuperClustersUncleaned.

WF 139.001 has the same chain as far as I can see.

The reason the multi5x5 modules are run is not just because of a keep statement of them in an output module.