Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep][Performance] Use DDFilteredView::level instead of copyNos().size() #31509

Closed
ianna opened this issue Sep 18, 2020 · 6 comments
Closed

Comments

@ianna
Copy link
Contributor

ianna commented Sep 18, 2020

The following code uses DDFiltereView::copyNos().size() where a DDFiltereView::level() is sufficient:

Geometry/VeryForwardGeometryBuilder/src/DetGeomDesc.cc
Geometry/GEMGeometryBuilder/src/ME0GeometryBuilder.cc
Geometry/GEMGeometryBuilder/src/GEMGeometryBuilder.cc
Geometry/CaloEventSetup/interface/CaloGeometryLoader.icc
Geometry/HGCalCommonData/src/HGCalGeomParameters.cc

@bsunanda - could you, please, look into it after the PR #31508 is merged? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @ianna Ianna Osborne.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign geometry

@cmsbuild
Copy link
Contributor

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@ianna
Copy link
Contributor Author

ianna commented Sep 25, 2020

HGcal, Calo, GEM, ME0 addressed via #31525

@ianna
Copy link
Contributor Author

ianna commented Sep 30, 2020

+1

@ianna ianna closed this as completed Sep 30, 2020
@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants