Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize btagbtvdeep::seedingTracksToFeatures re DeepVertex (or deep flavor+vertex combined) tagging #32114

Open
slava77 opened this issue Nov 11, 2020 · 6 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Nov 11, 2020

as a part of #31988 (#31988 (comment)) we find that the btagbtvdeep::seedingTracksToFeatures is pretty expensive.
At a quick glance, its implementation is rather suboptimal and can be sped up by caching relevant data per track instead of recomputing it in a nested loop over tracks.

https://legianni.web.cern.ch/legianni/cgi-bin/igprof-navigator/testMINI+bTag/cpu1K/276
may be of help, in addition to the code itself

@leonardogiannini

@slava77
Copy link
Contributor Author

slava77 commented Nov 11, 2020

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented Apr 1, 2022

type performance-improvements

@jpata
Copy link
Contributor

jpata commented May 17, 2022

type btv

@jpata
Copy link
Contributor

jpata commented May 17, 2022

@leonardogiannini what's the status here?

@cmsbuild cmsbuild added the btv label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants