Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit use of HitPattern in DataFormats/Scouting #32219

Closed
makortel opened this issue Nov 20, 2020 · 16 comments
Closed

Revisit use of HitPattern in DataFormats/Scouting #32219

makortel opened this issue Nov 20, 2020 · 16 comments

Comments

@makortel
Copy link
Contributor

#31962 added use of complex data structure reco::HitPattern in Run3ScoutingMuon. It was agreed to revisit that usage before the data taking of Run3 to either remove the usage (as too heavy for production use), or replace with e.g. a frozen version of HitPattern that could be easy to guarantee to be read in any later release.

The purpose of this issue is to act as a reminder.

@cmsbuild
Copy link
Contributor

A new Issue was created by @makortel Matti Kortelainen.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

assign core,hlt

@cmsbuild
Copy link
Contributor

New categories assigned: core,hlt

@Dr15Jones,@smuzaffar,@makortel,@Martin-Grunewald,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel
Copy link
Contributor Author

Any news yet on whether HitPattern like information will be needed for Run3ScoutingMuon? @jsalfeld

@jsalfeld
Copy link
Contributor

@mmasciov wanted to check

(cc'ing @dsperka )

@silviodonato
Copy link
Contributor

I remember about this issue. Thank you Matti and Jakob for raising this up. I will keep this in mind that this need to be solved much before the data taking.
cc @acostad

@makortel
Copy link
Contributor Author

Is there any chance this question could be resolved already for 12_1_0?

@mmasciov
Copy link
Contributor

@makortel: if it is OK with you, given that recent measurements by @dsperka showed that HitPattern for Run3ScoutingMuon shall not be heavy at all, I'll go with option (2). I.e., I'll make a frozen copy of HitPattern for scouting, and use such copy in Run3ScoutingMuon.

@mmasciov
Copy link
Contributor

As for the timeline, this option should be fast, and in time for 12_1_0 (before 19th of October).

@makortel
Copy link
Contributor Author

Thanks @mmasciov, that option is fine. For the record, could you give pointer to

@dsperka showed that HitPattern for Run3ScoutingMuon shall not be heavy at all

?

@mmasciov
Copy link
Contributor

The latest slides showing that muons are little in size should be: https://indico.cern.ch/event/1066775/contributions/4492263/attachments/2301466/3914859/scouting_event_content_xpog.pdf
However, @dsperka may have more recent/accurate numbers.

@VinInn
Copy link
Contributor

VinInn commented Sep 24, 2021

If possible I would change current HitPattern to

template<int N>
HitPatternT;

and then have to aliases
using HitPattern = HitPatternT<kOfflineHitPatternSize>;
and
using HitPatternScouting = HitPatternT<kScoutingHitPatternSize>;

if (kScoutingHitPatternSize==kOfflineHitPatternSize) memcpy is enough
if (kScoutingHitPatternSize<kOfflineHitPatternSize) a custom copy constructor should work.
I do not expect kScoutingHitPatternSize>kOfflineHitPatternSize will ever happen....

up to the expert to guess the proper versioning mechanism for the offline version

@slava77
Copy link
Contributor

slava77 commented Sep 24, 2021

if the past can be a reference for possible developments, the size of the array is not the only thing that can change; other data members (indices) can change as well.

@missirol
Copy link
Contributor

missirol commented Mar 8, 2022

@makortel
Copy link
Contributor Author

makortel commented Mar 8, 2022

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants