[DD4hep] DD4hep Ecal Endcap algo uses old DD utilities

[cvuosalo]

The DD4hep Geometry/EcalCommonData/plugins/dd4hep/DDEcalEndcapAlgo.cc uses Geometry/EcalCommonData/interface/DDEcalEndcapTrap.h, which utilizes old DD utilities like DDRotationMatrix and DDTranslation. Old DD dependencies should be removed from DD4hep code.

[cmsbuild]

A new Issue was created by @cvuosalo Carl Vuosalo.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[cvuosalo]

assign geometry

[cmsbuild]

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@civanch,@ianna,@mdhildreth,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cvuosalo]

@bsunanda Could you please take a look at this?

[cvuosalo]

The old DD utilities are just aliases of ROOT classes, so they are harmless, but we would prefer not to use old DD names in DDh4ep code.

[civanch]

@bsunanda , @cvuosalo , is this issue fixed?

[bsunanda]

Yes we have fixed that

…

________________________________ From: Vladimir Ivantchenko ***@***.*** Sent: 09 June 2021 15:46 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] [DD4hep] DD4hep Ecal Endcap algo uses old DD utilities (#33571) @bsunanda<https://github.com/bsunanda> , @cvuosalo<https://github.com/cvuosalo> , is this issue fixed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#33571 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOVGQFPV7EU5IG5Y66LTR5WE7ANCNFSM43X2EFVQ>.

[civanch]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.

[qliphy]

fixed by #33600