Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] [Cosmetic] Harmless warning messages about overwriting some constants should be quieted by removing duplicate definitions #33712

Closed
cvuosalo opened this issue May 12, 2021 · 9 comments

Comments

@cvuosalo
Copy link
Contributor

cvuosalo commented May 12, 2021

When the DD4hep geometry is built, the following warning messages are output:

Evaluator        WARN  +++ Overwriting variable: name=world_x value=101*m  Evaluator::Object : existing variable [setVariable error]
Evaluator        WARN  +++ Overwriting variable: name=world_y value=101*m  Evaluator::Object : existing variable [setVariable error]
Evaluator        WARN  +++ Overwriting variable: name=world_z value=450*m  Evaluator::Object : existing variable [setVariable error]

Step 1 of the DD4hep workflow 11634.911 shows these messages.
The problem is that these variables have duplicate definitions in XML files and in DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc. The duplicate definitions need to be found and removed so these constants are only defined once.
These warnings are harmless, but it would be better to remove them by eliminating the duplicate definitions.

@cmsbuild
Copy link
Contributor

A new Issue was created by @cvuosalo Carl Vuosalo.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor Author

@ianna FYI, as you requested

@cvuosalo
Copy link
Contributor Author

assign geometry

@cmsbuild
Copy link
Contributor

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@civanch,@ianna,@mdhildreth,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cvuosalo cvuosalo changed the title [DD4hep] Duplicate definitions of Geometry XML constants create warning messages -- need to remove duplication [DD4hep] [Cosmetic] Harmless warning messages about overwriting some constants should be quieted by removing duplicate definitions Jun 12, 2021
@cvuosalo
Copy link
Contributor Author

This issue is more complex than expected. These parameters do not appear in any of the xml files used in defining the scenario. They are entered in the file:
DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc

They may need to be defined there. There may be conflicts within dd4hep code which may try to define the same name elsewhere.

@cvuosalo
Copy link
Contributor Author

The source of these warnings is inside of DD4hep. A DD4hep issue has been opened:
AIDASoft/DD4hep#844

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Oct 8, 2021

Issue resolved by #35594.

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Oct 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2021

This issue is fully signed and ready to be closed.

@cvuosalo cvuosalo closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants