Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete/unused RPC code to be either cleaned up or updated #33761

Open
perrotta opened this issue May 18, 2021 · 5 comments
Open

Obsolete/unused RPC code to be either cleaned up or updated #33761

perrotta opened this issue May 18, 2021 · 5 comments

Comments

@perrotta
Copy link
Contributor

There is some code in the RPC local reco which is evidently never or only privately used, as also pointed out in the review of #33753 where the example was hit of the RPCSeedOverlapper in RecoMuon/MuonSeedGenerator and the two related configs

  • DQM/RPCMonitorDigi/python/RPCMuonSeeds_cfi.py
  • DQM/RPCMonitorDigi/python/RPCSeedGenerator_cff.py

Some update will be needed to update that RPCSeedOverlapper at a production level, for example:

  • move to thread safe EDProducers instead of the legacy one
  • replace cout's with thread safe Log messages
  • ...

If that code is not intended for central production, I see two possible ways out. Either

  • remove it from the release if not needed, and thus avoid maintenanca burdens, or
  • move it into a test area, if only used privately by some expert user

I'd suggest @cms-sw/rpc-dpg-l2 to have a look at that code, and at some possible additional one in their own area, that can be either cleaned up or updated.

@perrotta
Copy link
Contributor Author

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @perrotta .

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented May 17, 2022

@cms-sw/rpc-dpg-l2 @jhgoh @mileva kind ping on this. Looks like something was addressed in #33854, but as I understand, there is still some unused RPC code in the repo.

@jpata
Copy link
Contributor

jpata commented May 17, 2022

type rpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants