You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is some code in the RPC local reco which is evidently never or only privately used, as also pointed out in the review of #33753 where the example was hit of the RPCSeedOverlapper in RecoMuon/MuonSeedGenerator and the two related configs
DQM/RPCMonitorDigi/python/RPCMuonSeeds_cfi.py
DQM/RPCMonitorDigi/python/RPCSeedGenerator_cff.py
Some update will be needed to update that RPCSeedOverlapper at a production level, for example:
move to thread safe EDProducers instead of the legacy one
replace cout's with thread safe Log messages
...
If that code is not intended for central production, I see two possible ways out. Either
remove it from the release if not needed, and thus avoid maintenanca burdens, or
move it into a test area, if only used privately by some expert user
I'd suggest @cms-sw/rpc-dpg-l2 to have a look at that code, and at some possible additional one in their own area, that can be either cleaned up or updated.
The text was updated successfully, but these errors were encountered:
@cms-sw/rpc-dpg-l2 @jhgoh@mileva kind ping on this. Looks like something was addressed in #33854, but as I understand, there is still some unused RPC code in the repo.
There is some code in the RPC local reco which is evidently never or only privately used, as also pointed out in the review of #33753 where the example was hit of the RPCSeedOverlapper in RecoMuon/MuonSeedGenerator and the two related configs
Some update will be needed to update that RPCSeedOverlapper at a production level, for example:
If that code is not intended for central production, I see two possible ways out. Either
I'd suggest @cms-sw/rpc-dpg-l2 to have a look at that code, and at some possible additional one in their own area, that can be either cleaned up or updated.
The text was updated successfully, but these errors were encountered: