Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potentially incorrect python syntax in trigTools.py #33967

Closed
davidlange6 opened this issue Jun 3, 2021 · 8 comments
Closed

potentially incorrect python syntax in trigTools.py #33967

davidlange6 opened this issue Jun 3, 2021 · 8 comments

Comments

@davidlange6
Copy link
Contributor

I noticed that our python3 builds generate this warning - the result of these checks is potentially not what was intended.

if not path is '':
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-02-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:174: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-02-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:263: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if not path is '':
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-02-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:276: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-02-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:414: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-02-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:530: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':
/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-06-02-2300/python/PhysicsTools/PatAlgos/tools/trigTools.py:742: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if outputModule is not '':

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

A new Issue was created by @davidlange6 David Lange.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Jun 3, 2021

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2021

assign xpog

the errors point to code introduced in 2010; it's in the part that reco has not really followed
da63669

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2021

New categories assigned: xpog

@fgolf,@mariadalfonso,@gouskos you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor

slava77 commented Jul 22, 2021

+reconstruction

via #34253

@mariadalfonso
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants