Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT validation tests #34387

Closed
smuzaffar opened this issue Jul 7, 2021 · 18 comments
Closed

HLT validation tests #34387

smuzaffar opened this issue Jul 7, 2021 · 18 comments

Comments

@smuzaffar
Copy link
Contributor

smuzaffar commented Jul 7, 2021

HLT validation results on IB page are now marked failed if bot finds any tests exiting with non-zero status (
As reported #34231 (comment) ).

@Martin-Grunewald we are running HLT tests for all IBs (5.3.X to latest 12.0.X) and it is failing in few of the release cycles e.g. 5.3.X, 7.1.X, 8.0.X and 10.6.X. Can we stop it for old release cycles?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

A new Issue was created by @smuzaffar Malik Shahzad Muzaffar.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

assign hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

New categories assigned: hlt

@fwyzard,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fwyzard
Copy link
Contributor

fwyzard commented Jul 7, 2021

For what release cycles do we expect to run step2 / step3 MC production in the future ?

@Martin-Grunewald
Copy link
Contributor

What happened, the link to the "HLT Validation Tests" has disappeared from the IB pages:
https://cmssdt.cern.ch/SDT/html/showIB.html
??

@makortel
Copy link
Contributor

makortel commented Jul 8, 2021

What happened, the link to the "HLT Validation Tests" has disappeared from the IB pages:
https://cmssdt.cern.ch/SDT/html/showIB.html

That is the (very) old version of the IB pages. The HLT tests are shown in the current IB pages https://cmssdt.cern.ch/SDT/html/cmssdt-ib under the name "HLT" (and it is currently showing failure that is different from #34231 (comment))

@smuzaffar Should we think of removing the old IB pages to avoid confusion?

@smuzaffar
Copy link
Contributor Author

yes it is time to get rid of old page (which is not maintained any more). I will announce it to HN and set a apache redirection to go to the new Ib pages

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Jul 8, 2021

OK, I'll have a look and submit PRs where needed.
53X: #34418
71X: #34425

@Martin-Grunewald
Copy link
Contributor

Partial fix for 80X: #34484
(Other problems in 80X seem to be genuine, need to investigate)

@smuzaffar
Copy link
Contributor Author

@Martin-Grunewald , HLT tests run for all release cycles. Can we stop runing these tests for old release cycles e.g. 5.3.X up to 10.X?

@Martin-Grunewald
Copy link
Contributor

Hmm, why? Any specific reason?
(I'd like keep them alive for all open releases with IBs - but am always in favor of closing releases!)

@smuzaffar
Copy link
Contributor Author

Takes a lot of build resources (e.g. over 3 hours per IB on a 24 core machine). Although we do not build older release cycles every day but on Sunday (when we force build all IBs) it slows down the builds.

@Martin-Grunewald
Copy link
Contributor

Well, I would be in favor of closing more currently active CMSSW releases to lighten the load, but if it helps then ok, stop the tests for old releases but keep them for 11 and up.

@smuzaffar
Copy link
Contributor Author

Coming back to this, last week during Core SW meeting we discussed this again and would like to stop HLT tests for CMSSW 5.X till 10.X release cycles. This will still leave 10 releases cycles (11.0.X up to 13.0.X) for which we will run HLT tests. By the way, in old release cycles this test was taking 2-3 hours on 24 code nodes but now it takes 7 to 8 hours on 32 core HTCondor nodes . Are we sure all these HLT tests are properly utilizing the resources and are running in parallel ?

@Martin-Grunewald
Copy link
Contributor

Hmm, I see your point but would rather we close some old(er) CMSSW release cycles for good! Has this option been looked at? Once could always re-activate them in case of need (and then with HLT tests still there to make sure things work).

@smuzaffar
Copy link
Contributor Author

We had disabled few of the old release cycles and reduce the build frequency for most of the production release cycles. So things are in better state now. There are still few old release cycles 5.X, 8.X, 9.X for which we are building IBs and I would still like to keep those IBs alive just to make sure that we can build releases using old packaging tools and OS (slc6).

I am only wondering if HLT tests really need to run for all of the releases? It is enough to run these tests for those releases which were used by hlt?

@Martin-Grunewald
Copy link
Contributor

Hmm, we'd need to keep for all the releases used in data taking, and for which MC production is run, ie, in the end all releases which are kept alive (assuming that's the reason we keep releases alive?).

@smuzaffar
Copy link
Contributor Author

closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants