Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBSAN] Undefined behavior in DataFormats/* #35013

Closed
mrodozov opened this issue Aug 25, 2021 · 7 comments
Closed

[UBSAN] Undefined behavior in DataFormats/* #35013

mrodozov opened this issue Aug 25, 2021 · 7 comments

Comments

@mrodozov
Copy link
Contributor

mrodozov commented Aug 25, 2021

The UBSAN IB reports undefined behavior in 6 files, with example relval and step they appear in:

134.99603 step3
DataFormats/L1CSCTrackFinder/src/L1Track.cc:55:19: runtime error: load of value 216, which is not a valid value for type 'bool'

13.0 step2
DataFormats/L1GlobalMuonTrigger/src/L1MuGMTReadoutRecord.cc:314:21: runtime error: shift exponent -1 is negative

38634.0 step2
DataFormats/L1THGCal/interface/HGCalClusterT.h:20:9: runtime error: load of value 119, which is not a valid value for type 'bool'

136.751 step3
DataFormats/L1TMuon/interface/L1MuKBMTrack.h:19:7: runtime error: load of value 192, which is not a valid value for type 

136.751 step3
DataFormats/L1TMuon/src/L1MuBMTrackSegPhi.cc:87:16: runtime error: load of value 12, which is not a valid value for type 'bool'

134.706 step3
DataFormats/L1Trigger/interface/EtSum.h:20:9: runtime error: load of value 536870911, which is not a valid value for type 'EtSumType'

for reference use the latest UBSAN IB:
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_12_1/2021-08-20-2300?selectedArchs=slc7_amd64_gcc10&selectedFlavors=UBSAN_X&selectedStatus=passed&selectedStatus=failed

@mrodozov
Copy link
Contributor Author

assign l1

@cmsbuild
Copy link
Contributor

New categories assigned: l1

@rekovic,@cecilecaillol you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @mrodozov Mircho Rodozov.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

please check the relval logs in here for the examples:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/ubsan_logs/relvals/

@cecilecaillol
Copy link
Contributor

First 2 warnings addressed in #38060, others addressed previously

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants