[UBSAN] 'value' may be used uninitialized in GBRForestTools.cc

[iarspider]

UBSAN

src/CommonTools/MVAUtils/src/GBRForestTools.cc: In function 'std::unique_ptr<GBRForest> {anonymous}::init(const string&, std::vector<std::__cxx11::basic_string<char> >&)':
  src/CommonTools/MVAUtils/src/GBRForestTools.cc:163:18: warning: 'value' may be used uninitialized in this function [-Wmaybe-uninitialized]
   163 |       info[name] = value;

source

Maybe check return values of all QueryFooAttribute calls - just in case the XML format changes?

[cmsbuild]

A new Issue was created by @iarspider .

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[iarspider]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

[jpata]

+reconstruction

• I no longer see GBRForestTools.cc in the UBSAN list.
• looking in the history, I think it was addressed here: Avoid use of uninitalized values in GBRForestTools #35705

[jpata]

@cmsbuild please close

[cmsbuild]

This issue is fully signed and ready to be closed.