Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_2_X] Crash in FastjetJetProducer: "Did not specify appropriate inputs for VirtualJetProducer" #36322

Closed
johnalison opened this issue Dec 1, 2021 · 22 comments

Comments

@johnalison
Copy link
Contributor

Hello I am seeing a crash when producing ak4PFJets in rel CMSSW_12_2_0_pre2.

I see:
"Did not specify appropriate inputs for VirtualJetProducer, Abort!"
Full print out below.

Seems to be coming from
process.ak4PFJets = cms.EDProducer("FastjetJetProducer",
created from
from PhysicsTools.PatAlgos.tools.jetTools import *
updateJetCollection(...)

Think it could be related to
#35276
or
#35078

Any suggestions ?

----- Begin Fatal Exception 01-Dec-2021 16:30:31 CET-----------------------
An exception of category 'Invalid Jet Inputs' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'p'
   [2] Prefetching for module BTagAnalyzer/'btagana'
   [3] Prefetching for module PATJetSelector/'selectedUpdatedPatJetsPFlow'
   [4] Prefetching for module PATJetUpdater/'updatedPatJetsTransientCorrectedPFlow'
   [5] Prefetching for module DeepFlavourJetTagsProducer/'pfDeepCSVJetTagsPFlow'
   [6] Prefetching for module DeepNNTagInfoProducer/'pfDeepCSVTagInfosPFlow'
   [7] Prefetching for module CandSecondaryVertexProducer/'pfInclusiveSecondaryVertexFinderTagInfosPFlow'
   [8] Prefetching for module PuppiProducer/'packedpuppi'
   [9] Prefetching for module PFCandidatePrimaryVertexSorter/'primaryVertexAssociationJME'
   [10] Calling method for module FastjetJetProducer/'ak4PFJets'
Exception Message:
Did not specify appropriate inputs for VirtualJetProducer, Abort!
----- End Fatal Exception -------------------------------------------------
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

A new Issue was created by @johnalison John Alison.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@johnalison
Copy link
Contributor Author

Tagging @SWuchterl @soureek @rappoccio
@rappoccio , I forget who else commented in PPD about this issue. Can you add them here too?

@makortel
Copy link
Contributor

makortel commented Dec 1, 2021

assign reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

New categories assigned: reconstruction

@slava77,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel
Copy link
Contributor

makortel commented Dec 1, 2021

@johnalison Could you provide a full recipe to reproduce the problem?

@johnalison
Copy link
Contributor Author

johnalison commented Dec 1, 2021

cmsrel CMSSW_12_2_0_pre2
cd CMSSW_12_2_0_pre2/src
cmsenv
export CMSSW_GIT_REFERENCE=/cvmfs/cms.cern.ch/cmssw.git.daily
git cms-init
git clone -b 12_2_X --depth=1 git@github.com:cms-btv-pog/RecoBTag-PerformanceMeasurements.git RecoBTag/PerformanceMeasurements
scram b -j
cd RecoBTag/PerformanceMeasurements/test
cmsRun runBTagAnalyzer_cfg.py defaults=Run3_HighStats_pre2_mkFit  runOnData=False

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2021

@laurenhay @cms-sw/jetmet-pog-l2
please take a note

@rappoccio
Copy link
Contributor

Thanks @johnalison. If this is related to the ESConsumes migration, I think the downstream client code will have to be updated. Can you point out the "btagana" module?

@johnalison
Copy link
Contributor Author

OK thanks,
btagana is
https://github.com/cms-btv-pog/RecoBTag-PerformanceMeasurements/blob/12_2_X/plugins/BTagAnalyzer.cc

Are there instructions/an example for how to do the migration ?

@rappoccio
Copy link
Contributor

I don't think there are instructions, unless @Dr15Jones has some in his back pocket somewhere? :)

@Dr15Jones
Copy link
Contributor

Dr15Jones commented Dec 1, 2021

@rappoccio
Copy link
Contributor

Thanks Chris @Dr15Jones !

@makortel
Copy link
Contributor

makortel commented Dec 1, 2021

If I read the code correctly, the exception is thrown in

throw cms::Exception("Invalid Jet Inputs")
<< "Did not specify appropriate inputs for VirtualJetProducer, Abort!\n";

when all of the attempts to read input objects failed. I can not imagine how that could be caused by missing esConsumes (that should lead to very different kind of exception message). Written that, migrating BTagAnalyzer would be needed anyway.

@johnalison
Copy link
Contributor Author

I agree that the issue is not related to the esConsumes

@laurenhay
Copy link
Contributor

I successfully ran the PatAlgos unit tests (with updated files as the ones currently living in CMSSW at https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatAlgos/python/patInputFiles_cff.py are deprecated). This leads me to believe the issue lives in the bTagAnalyzer in some inconsistency with recent changes in cmssw and not in the JetProducers themselves.

@rappoccio
Copy link
Contributor

@johnalison any ideas? It looks like it's on the BTV custom validation side?

@jpata
Copy link
Contributor

jpata commented May 5, 2022

type btv

@cmsbuild cmsbuild added the btv label May 5, 2022
@jpata
Copy link
Contributor

jpata commented May 5, 2022

@johnalison is this being addressed in BTV? or should it be closed / moved to a BTV repo?

@johnalison
Copy link
Contributor Author

johnalison commented May 5, 2022 via email

@rappoccio
Copy link
Contributor

Hi, @johnalison I think you have to close, thanks!

@jpata
Copy link
Contributor

jpata commented May 25, 2022

-reconstruction

  • the issue is in BTV private code, not in the reco code in CMSSW

@jpata
Copy link
Contributor

jpata commented May 25, 2022

@cmsbuild please close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants