Implementation of CorrelationThreeBodyByTwoBodyTemplate missing

[makortel]

UBSAN build CMSSW_12_3_UBSAN_X_2021-12-17-2300 is failing with

>> Building  shared library tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/libL1TriggerL1TGlobal.so
/data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/c++ -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-deprecated-copy -Wno-unused-parameter -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -fno-omit-frame-pointer -fsanitize=undefined -fsanitize=builtin -fsanitize=pointer-overflow -shared -Wl,-E -Wl,-z,defs tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/a/L1TriggerL1TGlobal_xr.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/AlgorithmEvaluation.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CaloCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CaloTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/ConditionEvaluation.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyByTwoBodyCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrWithOverlapRemovalCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrelationTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrelationThreeBodyTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrelationWithOverlapRemovalTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/EnergySumCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/EnergySumTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/ExternalCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/ExternalTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/GlobalAlgorithm.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/GlobalBoard.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/GlobalCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/GlobalDefinitions.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/GlobalParamsHelper.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/GlobalScales.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/L1TGlobalUtil.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/L1TGlobalUtilHelper.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/MuCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/MuonShowerCondition.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/MuonShowerTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/MuonTemplate.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/PrescalesVetosFractHelper.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/PrescalesVetosHelper.cc.o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/TriggerMenu.cc.o -o tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/libL1TriggerL1TGlobal.so -Wl,-E -Wl,--hash-style=gnu -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/fa06e284a7f13c4c070242a4a66a3770/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_3_UBSAN_X_2021-12-17-2300/biglib/slc7_amd64_gcc11 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/fa06e284a7f13c4c070242a4a66a3770/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_3_UBSAN_X_2021-12-17-2300/lib/slc7_amd64_gcc11 -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/fa06e284a7f13c4c070242a4a66a3770/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_3_UBSAN_X_2021-12-17-2300/external/slc7_amd64_gcc11/lib -L/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/fa06e284a7f13c4c070242a4a66a3770/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_3_UBSAN_X_2021-12-17-2300/static/slc7_amd64_gcc11 -lDataFormatsL1TGlobal -lDataFormatsL1Trigger -lDataFormatsL1TrackTrigger -lCondFormatsDataRecord -lDataFormatsTrackerCommon -lCondFormatsL1TObjects -lDataFormatsGeometryCommonDetAlgo -lDataFormatsSiStripCluster -lGeometryRecords -lCondFormatsAlignmentRecord -lDataFormatsCandidate -lDataFormatsGeometrySurface -lDataFormatsL1GlobalCaloTrigger -lDataFormatsTrajectoryState -lDataFormatsCLHEP -lDataFormatsEcalDetId -lDataFormatsGeometryVector -lDataFormatsHcalDetId -lDataFormatsL1CaloTrigger -lDataFormatsL1GlobalTrigger -lDataFormatsSiPixelDetId -lDataFormatsSiStripDetId -lFWCoreFramework -lDataFormatsDetId -lDataFormatsL1GlobalMuonTrigger -lDataFormatsMath -lDataFormatsPhase2TrackerDigi -lDataFormatsSiPixelCluster -lDataFormatsSiStripDigi -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCorePluginManager -lFWCoreReflection -lCondFormatsSerialization -lFWCoreConcurrency -lFWCoreUtilities -lFWCoreVersion -lGenVector -lMathMore -lTree -lNet -lThread -lMathCore -lRIO -lboost_serialization -lCore -lboost_thread -lboost_date_time -lCLHEP -lpcre -lbz2 -lgsl -luuid -ltbb -lxerces-c -llzma -lz -lfmt -lcms-md5 -lopenblas -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2
  /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyByTwoBodyCondition.cc.o:(.data.rel+0x3518): undefined reference to `typeinfo for CorrelationThreeBodyByTwoBodyTemplate'
   /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyByTwoBodyCondition.cc.o:(.data.rel+0x6b98): undefined reference to `typeinfo for CorrelationThreeBodyByTwoBodyTemplate'
   /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyByTwoBodyCondition.cc.o:(.data.rel+0x6c18): undefined reference to `typeinfo for CorrelationThreeBodyByTwoBodyTemplate'
   /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyByTwoBodyCondition.cc.o:(.data.rel+0x6c98): undefined reference to `typeinfo for CorrelationThreeBodyByTwoBodyTemplate'
   /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyByTwoBodyCondition.cc.o:(.data.rel+0x7518): undefined reference to `typeinfo for CorrelationThreeBodyByTwoBodyTemplate'
   /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/CorrThreeBodyByTwoBodyCondition.cc.o:(.data.rel+0x7698): more undefined references to `typeinfo for CorrelationThreeBodyByTwoBodyTemplate' follow
 collect2: error: ld returned 1 exit status
  gmake: *** [tmp/slc7_amd64_gcc11/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/libL1TriggerL1TGlobal.so] Error 1
 Leaving library rule at L1Trigger/L1TGlobal

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_3_UBSAN_X_2021-12-17-2300/L1Trigger/L1TGlobal

The class in question has a header in

cmssw/L1Trigger/L1TGlobal/interface/CorrelationThreeBodyByTwoBodyTemplate.h

Lines 33 to 40 in 6d8172f

	class CorrelationThreeBodyByTwoBodyTemplate : public GlobalCondition {
	public:
	/// constructor(s)
	/// default
	CorrelationThreeBodyByTwoBodyTemplate();
	/// from condition name
	CorrelationThreeBodyByTwoBodyTemplate(const std::string&);

that declares the member functions, but I didn't see the member functions defined anywhere.

[makortel]

assign l1

[cmsbuild]

New categories assigned: l1

@epalencia,@rekovic,@cecilecaillol you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @makortel Matti Kortelainen.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[perrotta]

• Revert "Add CorrThreeBodyByTwoBodyCondition." #36610 reverts the offending PR Add CorrThreeBodyByTwoBodyCondition. #36441
• Please @rekovic provide an amended version of that PR at your earliest convenience

[rekovic]

Hi, I am working on this.

@makortel
Since normal jenkins tests were passing, what alternative compilation command, or release, recipe, should I use to test the fix? Thanx.

[makortel]

Best would be to have the added code to be used in any kind of test (e.g. runTheMatrix workflow, unit test, addOn test), or even called by "cold code" (I believe that should have been sufficient to catch the missing implementation). Of course UBSAN IBs can be tested explicitly too, but so far UBSAN build failures have been rare enough to warrant discovering them only in IBs (rather than spending more resources for PR tests).

[cecilecaillol]

This issue can be closed. The code for tau-> 3mu decays was merged #36758

[cecilecaillol]

+l1

[cmsbuild]

This issue is fully signed and ready to be closed.