Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in ele_trigger after adding HLT to Phase-2 workflow #40700

Closed
srimanob opened this issue Feb 6, 2023 · 7 comments
Closed

Change in ele_trigger after adding HLT to Phase-2 workflow #40700

srimanob opened this issue Feb 6, 2023 · 7 comments

Comments

@srimanob
Copy link
Contributor

srimanob commented Feb 6, 2023

This is to follow up on the difference in ele_trigger plot after merging #40412

See comment: #40665 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Feb 6, 2023

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

New categories assigned: upgrade

@AdrianoDee,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

@missirol
Copy link
Contributor

missirol commented Feb 6, 2023

What is the issue exactly?

This kind of difference is expected, because that MonitorElement is filled based on TriggerResults::HLT, and #40412 changed the HLT menu used in those wfs (thus, the change in the MonitorElement).

That said, this MonitorElement does not seem very useful to me (we have a dedicated plugin to monitor the TriggerResults of HLT in the offline DQM, i.e. HLTFiltersDQMonitor). Maybe it could be removed, but this is up to DQM and E/Gamma.

@missirol
Copy link
Contributor

please close

The extra histograms that introduced confusion were removed in #40788 and #40806.

@srimanob
Copy link
Contributor Author

+upgrade

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants