Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDAQ removal -- Fix compilation problem in CSC / DT commissioning code #823

Closed
ktf opened this issue Sep 13, 2013 · 6 comments
Closed

XDAQ removal -- Fix compilation problem in CSC / DT commissioning code #823

ktf opened this issue Sep 13, 2013 · 6 comments

Comments

@ktf
Copy link
Contributor

ktf commented Sep 13, 2013

Due to removal of IORawData/DaqSource in #814 (and related) it fails to compile:

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_0_X_2013-09-13-0200/IORawData/CSCCommissioning
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_0_X_2013-09-13-0200/IORawData/DTCommissioning

I suspect this needs to use a file based source?

@emeschi @ptcox any suggestions?

@Dr15Jones
Copy link
Contributor

@wmtan Bill, was this a change you made to use a base class?

@wmtan
Copy link
Contributor

wmtan commented Sep 13, 2013

No. This is from the removal of IORawData/DaqSource, which is replaced by the file based source. That was not done by me.

@Dr15Jones
Copy link
Contributor

@wmtan Sorry for the unclear question. I was asking if it was you who had added the IORawData/DaqSource dependency originally to this code as a way to share a base class for raw files.

@wmtan
Copy link
Contributor

wmtan commented Sep 13, 2013

No. The original CVS Buildiles for these packages (7 years and 9 months ago) show the DaqSource dependency.
I did not write them.

@ktf
Copy link
Contributor Author

ktf commented Sep 13, 2013

I've removed the incriminated packages for now in #828. Keeping this open, but moving it to pre5.

@ktf
Copy link
Contributor Author

ktf commented Nov 1, 2013

Ok… I guess no one cares about this for the moment. Closing it.

@ktf ktf closed this as completed Nov 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants