Fixes to some issues reported by static analyzer in tracking related code

[makortel]

This PR attempts to fix some of the issues reported by static analyzer in tracking (and related) code.

Tested in CMSSW_7_6_X_2015-06-30-2300, no changes expected in standard workflows.

@rovere @VinInn

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Fixes to some issues reported by static analyzer in tracking related code

It involves the following packages:

DQM/SiStripMonitorTrack
RecoTracker/ConversionSeedGenerators
RecoTracker/FinalTrackSelectors
RecoTracker/SingleTrackPattern
RecoTracker/TkHitPairs
RecoTracker/TkSeedGenerator
RecoTracker/TkTrackingRegions
RecoTracker/TrackProducer
RecoVertex/BeamSpotProducer
RecoVertex/VertexTools
SimG4CMS/Tracker
SimGeneral/TrackingAnalysis
SimTracker/TrackerHitAssociation
TrackPropagation/SteppingHelixPropagator
TrackingTools/TrackAssociator
Validation/RecoTrack
Validation/RecoVertex

@civanch, @diguida, @cvuosalo, @mdhildreth, @cmsbuild, @cerminar, @deguio, @slava77, @mmusich, @danduggan can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @threus, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @bellan, @istaslis, @mschrode, @rovere, @wmtford, @gpetruc, @cerati, @trocino, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[diguida]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[deguio]

+1

[slava77]

+1

for #10066 2738698

• compared to the previous "+1" for 5f95bc2, changes are only to back-out a change (revert to baseline) in HitPairGeneratorFromLayerPair.cc [related to reco code] and in SiStripTrackingRecHitsValid.h [only in validation]
• jenkins tests passed and comparisons with baseline show no (relevant) differrence