Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuning MVA cuts for lowPt and tobTec #10086

Merged
merged 1 commit into from
Jul 8, 2015

Conversation

mhwalker
Copy link
Contributor

@mhwalker mhwalker commented Jul 8, 2015

Retuned LowPtTripletStep highPurity MVA cut to remove the step in the chi2 distribution - it pretty much disappears.

Retuned TobTecStep highPurity MVA cut to recover some efficiency at high dxy. Most efficiency lost for dxy < 50 cm recovered.

effvspos
tuning

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

A new Pull Request was created by @mhwalker (Matthew Walker) for CMSSW_7_5_X.

tuning MVA cuts for lowPt and tobTec

It involves the following packages:

RecoTracker/IterativeTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@VinInn
Copy link
Contributor

VinInn commented Jul 8, 2015

Let's go with this, we can retune later...

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2015

@VinInn @rovere
I suppose we are giving up on vxy>50 cm, right?
(efficiency for vxy>50 cm look about the same in pre4.vs.pre5 comparisons as in pre4.vs.fixFromThisPR)

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2015

@cmsbuild please test
at least the change in the code looks next to trivial, nice.
There are no payloads changes, right?
@mhwalker please confirm

@mhwalker
Copy link
Contributor Author

mhwalker commented Jul 8, 2015

@slava77 Correct, no payload changes, only changing the cut value.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2015

+1

for #10086 bbfedcc

  • tested in CMSSW_7_5_0_pre6 /test area sign569/ including higher stat tests (still not much to get a high precision picture)
  • the efficiency in high purity tracks is slightly higher for tracks with larger displacement (in agreement with the plots from Matt)
  • generalTracks distributions are almost unchanged (as expected: only high-purity assignment changes)
  • in ttbar and dijet events there is also a fairly similar noticeable change in the number of higher level objects or other tracks:
    • ~5-10% increase in recoConversions (in gamma 35 sample it's even more significant: ~30% more single leg conversions in the barrel, and 10% more in the endcap)
    • ~0.5% increase in pf candidates
    • ~1.5% increase in electronGsfTracks

flat-pt dijet sample (400 events here)
wf1313_hp_eff_vs_vtx

the rest if the plots are with ttbar run1-like (pu~20; 200 events here, just higher stat test)
in line with the plot from Matt
wf202_hp_eff_vs_vtxpos

wf202_hp_eff_vs_dxy

wf202_hp_dups_vs_eta
wf202_hp_fake_vs_eta

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2015

(NB: my plots were in a comparison with 750pre6 [black])

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants