Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "migrating to multithreading of RPCPointProducer" (75X) #10107

Conversation

Martin-Grunewald
Copy link
Contributor

Reverts #9100

@Martin-Grunewald Martin-Grunewald changed the title Revert "migrating to multithreading of RPCPointProducer" Revert "migrating to multithreading of RPCPointProducer" (75X) Jul 9, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jul 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_5_X.

Revert "migrating to multithreading of RPCPointProducer" (75X)

It involves the following packages:

RecoLocalMuon/RPCRecHit

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor Author

I am using this PR to check whether the problem is indeed from #9100

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Pull request #10107 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

3 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Pull request #10107 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Pull request #10107 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Pull request #10107 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

@smuzaffar @nclopezo
Looks like cmsbot is in a loop stuck here, sending messages every 10 mins on "PR updated" while this is certainly not the case

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Pull request #10107 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

davidlange6 added a commit that referenced this pull request Jul 9, 2015
…caPathToMultiThread

Revert "migrating to multithreading of RPCPointProducer" (75X)
@davidlange6 davidlange6 merged commit b0cbcc8 into cms-sw:CMSSW_7_5_X Jul 9, 2015
@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones @HuguesBrun @davidlange6
I can confirm that this revert-PR fixes the problem I observe in 75X!
Hence, for 750final to be useful for TSG, either accept this PR or fix the original PR.

@HuguesBrun
Copy link
Contributor

Dear all,

I don't understand what is happening and I am even not able yet to reproduce the problem so maybe the best is to revert the PR.
I will resubmit it when I will have fixed this problem.

Sorry for having introduced this mess !
Hugues

@Martin-Grunewald Martin-Grunewald deleted the revert-9100-moveRPCalcaPathToMultiThread branch July 9, 2015 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants