Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GenLumiInfoProduct for a posteriori cross-section calculation #10173

Merged
merged 1 commit into from
Jul 31, 2015

Conversation

covarell
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @covarell (Roberto Covarelli) for CMSSW_7_6_X.

added GenLumiInfoProduct for a posteriori cross-section calculation

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Jul 13, 2015

@covarell I might have missed the discussion. Could you add a brief description of this PR? and Do you have an estimation of the file size increase? @gpetruc @arizzi

@covarell
Copy link
Contributor Author

I understood @bendavid had already provided size estimates to @gpetruc and this was considered OK

@bendavid
Copy link
Contributor

The dataformat is 12 doubles + 10 ints (and since it's a lumi product, for unskimmed MC that's 1 object per ~200 events). So I would say the size is negligible.

@gpetruc
Copy link
Contributor

gpetruc commented Jul 14, 2015

The back of the envelop estimate looks ok, but for safety can somebody
re-run miniAOD out of some MC sample to check? (30-50k events should
suffice, our usual benchmark is TTbar so you could try
/TTJets_TuneCUETP8M1_13TeV-madgraphMLM-pythia8/RunIISpring15DR74-Asympt25ns_MCRUN2_74_V9-v2/AODSIM
or
/TTJets_TuneCUETP8M1_13TeV-amcatnloFXFX-pythia8/RunIISpring15DR74-Asympt25ns_MCRUN2_74_V9-v1/AODSIM

Does the 200 events per lumi hold also in samples with low filter
efficiency (e.g.
/QCD_Pt-20toInf_MuEnrichedPt15_TuneCUETP8M1_13TeV_pythia8/RunIISpring15DR74-Asympt25ns_MCRUN2_74_V9-v1/AODSIM
https://cmsweb.cern.ch/das/request?input=dataset%3D%2FQCD_Pt-20toInf_MuEnrichedPt15_TuneCUETP8M1_13TeV_pythia8%2FRunIISpring15DR74-Asympt25ns_MCRUN2_74_V9-v1%2FAODSIM&instance=prod%2Fglobal
) ?

Giovanni

On Tue, Jul 14, 2015 at 11:08 AM, Josh Bendavid notifications@github.com
wrote:

The dataformat is 12 doubles + 10 ints (and since it's a lumi product, for
unskimmed MC that's 1 object per ~200 events). So I would say the size is
negligible.


Reply to this email directly or view it on GitHub
#10173 (comment).

@bendavid
Copy link
Contributor

Yes, the production system takes the matching*filter efficiency into account when setting number of events per lumi, so it's ~200events/lumi after matching and filtering.

@covarell
Copy link
Contributor Author

Hi Giovanni, I did this test:
SIZE WITHOUT GENLUMIINFO
-rw-r--r--. 1 covarell zh 294296017 22. Jul 17:38 miniAOD-prod_PAT.root

@covarell
Copy link
Contributor Author

SIZE WITH GENLUMIINFO
-rw-r--r--. 1 covarell zh 294492192 22. Jul 19:11 miniAOD-prod_PAT.root

The increase is only 0.7 permille on the ttbar event size.

@gpetruc
Copy link
Contributor

gpetruc commented Jul 22, 2015

Ok, looks fine for me.

Giovanni

On Wed, Jul 22, 2015 at 7:14 PM, Roberto Covarelli <notifications@github.com

wrote:

SIZE WITH GENLUMIINFO
-rw-r--r--. 1 covarell zh 294492192 22. Jul 19:11 miniAOD-prod_PAT.root

The increase is only 0.7 permille on the ttbar event size.


Reply to this email directly or view it on GitHub
#10173 (comment).

@covarell
Copy link
Contributor Author

@monttj can we merge this (and the corresponding PRs for 74X and 75X)? We would like to have this in for the possible re-miniAOD campaign

@monttj
Copy link
Contributor

monttj commented Jul 29, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants