Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary files in DOS format break current ROOT6 #1023

Merged
merged 1 commit into from
Oct 8, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 8, 2013

The current version of ROOT 6 (ROOT_5_99_04) produces dictionaries that do not compile if the header file (classes.h) is in DOS format. ROOT should fix this eventually, but this tag set modifies six classes.h file and one classes_def.xml file to be in Linux format instead of DOS format by removing the tailing carriage return on each line.
This is the only change in this pull request.

This request is purely techincal and totally trivial. Please bypass the signatures if not promptly signed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2013

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Dictionary files in DOS format break current ROOT6

It involves the following packages:

PhysicsTools/IsolationUtils
CondCore/Utilities
DataFormats/HeavyIonEvent
DataFormats/HepMCCandidate
CondTools/Utilities
SimDataFormats/TrackingAnalysis

@vciulli, @smuzaffar, @apfeiffer1, @thspeer, @civanch, @mdhildreth, @nclopezo, @giamman, @slava77, @ggovi, @vadler can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@vciulli
Copy link
Contributor

vciulli commented Oct 8, 2013

+1

On Oct 8, 2013, at 17:52, cmsbuild wrote:

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Dictionary files in DOS format break current ROOT6

It involves the following packages:

PhysicsTools/IsolationUtils
CondCore/Utilities
DataFormats/HeavyIonEvent
DataFormats/HepMCCandidate
CondTools/Utilities
SimDataFormats/TrackingAnalysis

@vciulli, @smuzaffar, @apfeiffer1, @thspeer, @civanch, @mdhildreth, @nclopezo, @giamman, @slava77, @ggovi, @vadler can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.


Reply to this email directly or view it on GitHub.

ktf added a commit that referenced this pull request Oct 8, 2013
ROOT6 fixes -- Dictionary files in DOS format break current ROOT6
@ktf ktf merged commit 3ef5796 into cms-sw:CMSSW_7_0_X Oct 8, 2013
@wmtan wmtan deleted the NoDOSFormatForDictionaryFiles branch October 11, 2013 17:09
BenjaminRS pushed a commit to BenjaminRS/cmssw that referenced this pull request Jun 10, 2022
Small change to SimL1Emulator (L1TrackerEmuEtMiss sequence)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants