Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for stage1 dqm #10463

Merged
merged 1 commit into from Aug 1, 2015

Conversation

jingyucms
Copy link
Contributor

Make a PR trying to fix:
Trying to fix 3 bugs for stage1 dqm:

  1. change Stage1 Client histogram folder
  2. make sure GMT fed will not be affected when swap GT fiber between stage1 and legacy
  3. restrict layer2 to unpack only 1Bx for data emulator comparison

Similar to #10360 , But since #10360 have a lot of bugs, I made this new PR and together with #10442 will replace #10360.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jingyucms (Jingyu Zhang) for CMSSW_7_4_X.

bug fix for stage1 dqm

It involves the following packages:

DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient
L1Trigger/Configuration
L1Trigger/HardwareValidation

@cmsbuild, @danduggan, @mulhearn, @deguio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 1be59e4
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 31-Jul-2015 21:31:32 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

4.22 step1

DAS Error

140.53 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10463/5160/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2015

@davidlange6
Copy link
Contributor

this introduces some changes in the 25ns MC - but am told it can not be avoided.

davidlange6 added a commit that referenced this pull request Aug 1, 2015
@davidlange6 davidlange6 merged commit 48ba547 into cms-sw:CMSSW_7_4_X Aug 1, 2015
@jingyucms jingyucms deleted the jingyu-74x-stage1-gmt branch December 4, 2015 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants