-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix r45Fraction_ calculation #10724
Fix r45Fraction_ calculation #10724
Conversation
A new Pull Request was created by @dertexaner for CMSSW_7_4_X. Fix r45Fraction_ calculation It involves the following packages: RecoMET/METAlgorithms @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
let's see the comparison results. Is this fix essential for simulation or is it affecting primarily values relevant for data? |
@slava77 The fix is primarily for 25ns data taking. |
@dertexaner do you have any plots for before and after? |
@slava77 Not directly. Attached are two files showing the 2D distribution of noisy energy fraction and the noisy hit fraction per RBX. RBXs in gray shaded regions are declared as noisy. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log ----- Begin Fatal Exception 13-Aug-2015 21:38:02 CEST----------------------- An exception of category 'Configuration' occurred while [0] Processing run: 1 lumi: 1 event: 1 [1] Running path 'validation_step' [2] Calling event method for module MixingModule/'mix' Exception Message: RootInputFileSequence::readOneSpecified(): no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 4.53 step1 DAS Error 1001.0 step1 DAS Error 1003.0 step1 DAS Error you can see the results of the tests here: |
@slava77 Would you know what the holdup is? |
we'll look at it today or tomorrow. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log ----- Begin Fatal Exception 14-Aug-2015 04:35:48 CEST----------------------- An exception of category 'Configuration' occurred while [0] Processing run: 1 lumi: 1 event: 1 [1] Running path 'digitisation_step' [2] Calling event method for module MixingModule/'mix' Exception Message: RootInputFileSequence::readOneRandom(): no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log ----- Begin Fatal Exception 14-Aug-2015 04:46:14 CEST----------------------- An exception of category 'Configuration' occurred while [0] Processing run: 1 lumi: 1 event: 1 [1] Running path 'validation_step' [2] Calling event method for module MixingModule/'mix' Exception Message: RootInputFileSequence::readOneSpecified(): no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- 4.53 step1 DAS Error 140.53 step1 DAS Error 1003.0 step1 DAS Error you can see the results of the tests here: |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Correcting a coding mistake to properly calculate the RBX HCAL noisy hits fraction. #10725 and #10726, the 75X and 76X versions of this PR, have already been merged. The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-08-14-1100 show no significant differences, since the fix covers a case that rarely occurs in standard workflows. A test of prompt reco against baseline CMSSW_7_4_9 using file /store/data/Run2015C/MET/RAW/v1/000/254/231/00000/B6DF41DA-8E41-E511-9DA0-02163E01476B.root shows no significant differences. Testing seems to indicate that the effect of this bug fix is very limited. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
This is a simple bug-fix for the noisy hit fraction (r45Fraction_ ) calculation in CommonHcalNoiseRBXData.
It is highly desirable to have this in the earliest possible 74X and 75X releases.