Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new features for offline Tk DQM scripts #10757

Merged
merged 2 commits into from
Nov 13, 2015

Conversation

vdutta
Copy link
Contributor

@vdutta vdutta commented Aug 13, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vdutta (Valentina Dutta) for CMSSW_7_4_X.

new features for offline Tk DQM scripts

It involves the following packages:

CalibTracker/SiStripQuality
DQM/SiStripMonitorClient

@diguida, @danduggan, @cerminar, @cmsbuild, @deguio, @mmusich can you please review it and eventually sign? Thanks.
@jlagram, @threus, @gbenelli, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Aug 14, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Aug 14, 2015

+1 for vdutta@7765474

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Sep 2, 2015

-1
rebase needed

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Pull request #10757 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@vdutta
Copy link
Contributor Author

vdutta commented Sep 2, 2015

Sorry, it's my first time trying a rebase so I'm not sure if I messed up the history. Please let me know if I should close this PR and open a new one instead.

@deguio
Copy link
Contributor

deguio commented Sep 7, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

@deguio
Copy link
Contributor

deguio commented Sep 11, 2015

+1

@diguida
Copy link
Contributor

diguida commented Oct 30, 2015

+1
backport of #10759 (already approved once, then forgot to re-approve)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 13, 2015
@cmsbuild cmsbuild merged commit 368a1f1 into cms-sw:CMSSW_7_4_X Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants