Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the HCAL logical map code to reflect the change in HO ring-0 int... #1081

Merged
merged 1 commit into from Oct 25, 2013

Conversation

weihuacern
Copy link
Contributor

...erface cards, installed during LS1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @weihua19900704 for CMSSW_7_0_X.

updated the HCAL logical map code to reflect the change in HO ring-0 int...

It involves the following packages:

CondFormats/HcalObjects
CalibCalorimetry/HcalAlgos

@smuzaffar, @apfeiffer1, @nclopezo, @demattia, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

@apfeiffer1
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

@nclopezo David, one of the Jenkins integration tests for this pull request seems to have been running for 21 hours

@nclopezo
Copy link
Contributor

@Dr15Jones

Hi Chris,

which of the jobs that are here do you mean?

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/

the tests for this one finished yesterday and took 34 minutes according to what I see here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/895/

@Dr15Jones
Copy link
Contributor

My fault, I misread the 21 hours since success as 21 hours of running

@demattia
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Oct 21, 2013

Is this really meant for 70X???

ktf added a commit that referenced this pull request Oct 25, 2013
updated the HCAL logical map code to reflect the change in HO ring-0 int...
@ktf ktf merged commit 3ad9025 into cms-sw:CMSSW_7_0_X Oct 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants