Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trigger feeding the pixel lumi dqm to match the VdM menu #10899

Merged

Conversation

rpatkennyiii
Copy link
Contributor

This is to fix the trigger feeding the pixel lumi dqm so that it matches the VdM trigger menu, and is identical to #10898

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mojoe137 (Pat Kenny) for CMSSW_7_5_X.

fix trigger feeding the pixel lumi dqm to match the VdM menu

It involves the following packages:

DQM/Integration

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@danduggan
Copy link
Contributor

please test

@danduggan
Copy link
Contributor

+1
for online only

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

1 similar comment
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: 93e2ffc
When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10899/7541/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9623/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Nov 10, 2015
fix trigger feeding the pixel lumi dqm to match the VdM menu
@davidlange6 davidlange6 merged commit 8b11806 into cms-sw:CMSSW_7_5_X Nov 10, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@rpatkennyiii rpatkennyiii deleted the pixelLumiDqmFixForVdM-75X branch November 19, 2015 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants