Change photon & electron regressions back to fractionized shower shapes

[lgray]

Use fraction-ized shower shapes in the photon and electron regressions, as is done in the training.

This is the result of closer double-checking with the person who produced the photon regression.

@matteosan1

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

Change photon regressions back to fractionized shower shapes

It involves the following packages:

RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

Pull request #10921 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

-1
Tested at: b1d7747
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10921/7574/summary.html

[lgray]

@cmsbuild please test

@slava77 I am done double checking for residual use of full5x5. Done messing with this PR.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 0c57abf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10921/7583/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10921/7583/summary.html

[slava77]

@lgray both
modifyObject(pat::Electron& ele) and modifyObject(pat::Photon& pho) were changed.
The PR description suggests it's only for photons.
Please confirm that the change is as desired.
And if so, please update the PR description

[lgray]

@slava77 done

[slava77]

+1

for #10921 0c57abf

• changes in the code are in line with the PR description
• jenkins tests passed and comparisons with baseline show minor differences in the miniAOD DQM for electrons
  the following plot is from 25202 (ttbar with PU=35@25ns MC run2)
  

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1