Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ROOT5 checksum known to ROOT6 #10931

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Make ROOT5 checksum known to ROOT6 #10931

merged 1 commit into from
Aug 31, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 24, 2015

Make a new ROOT5 checksum known in the ROOT6 releases.

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 24, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Make ROOT5 checksum known to ROOT6

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5e26872
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10931/7631/summary.html

@wmtan wmtan mentioned this pull request Aug 25, 2015
Closed
davidlange6 added a commit that referenced this pull request Aug 31, 2015
@davidlange6
Merge pull request #10931 from wmtan/MakeROOT5ChecksumKnown
e0db101 
Make ROOT5 checksum known to ROOT6
@davidlange6 davidlange6 merged commit e0db101 into cms-sw:CMSSW_7_5_X Aug 31, 2015
@wmtan wmtan deleted the MakeROOT5ChecksumKnown branch September 4, 2015 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
4 participants
@wmtan @cmsbuild @smuzaffar @davidlange6