-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed include guard in ESUnpacker.h #10950
Fixed include guard in ESUnpacker.h #10950
Conversation
The previous code had a mismatch between the macro named defined and the one being checked for the include guard. This is now fixed and the include guard now matches the standard CMS pattern.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. Fixed include guard in ESUnpacker.h It involves the following packages: EventFilter/ESRawToDigi @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Fixed include guard in ESUnpacker.h
The previous code had a mismatch between the macro named defined and
the one being checked for the include guard. This is now fixed and the
include guard now matches the standard CMS pattern.