Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test gem rec hit analyzer #11079

Merged

Conversation

pietverwilligen
Copy link
Contributor

port of analyzer used for test purposes to 76X release:

  • use of std::unique_ptr
  • getByToken

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

A new Pull Request was created by @pietverwilligen (Piet Verwilligen) for CMSSW_7_6_X.

Update test gem rec hit analyzer

It involves the following packages:

RecoLocalMuon/GEMRecHit

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Pull request #11079 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Sep 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 7, 2015

+1

For #11079 256da63

Migrating gem rec hit test code to use unique_ptr and getByToken. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-02-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Sep 8, 2015
@davidlange6 davidlange6 merged commit f545ad8 into cms-sw:CMSSW_7_6_X Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants