fix inner outer for OutIn

[VinInn]

and old bug (since ever)
need backport...

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_6_X.

fix inner outer for OutIn

It involves the following packages:

RecoTracker/TrackProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

@VinInn
What's the expected change in the tracking performance?

[cmsbuild]

The tests are being triggered in jenkins.

[VinInn]

Just correctness.
It is used in some analysis.
missing_inner is critical for electron/photon classification, less for muon.
btag may use it

[cmsbuild]

+1
Tested at: 3e1f7c3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11089/7835/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11089/7835/summary.html

[slava77]

+1

for #11089 3e1f7c3

• changes in the code are as expected; these became more obviously necessary with introduction of out-in tracking steps
• jenkins tests pass and comparisons with baseline don't show noticeable differences, except in 4.53 in packedCandidates diffHitPatternHasValidHitInFirstPixelBarrel (at 1 track in 10K level).
• local tests with higher stats show a change in the expected place: the outside-in step tracks now have their inner and outer missing hits swapped to the right place (mainly missing outer). This is present in plots with enough tracks and some muon activity
  
  
• in 1313 (3TeV dijet) there is also a tiny change in the inner hit parameters of the conversion info, which is most likely just a downstream effect of the above (rather than an effect on conversion tracking)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar