Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dummy parameters to HIMultiTrackSelector #11105

Merged
merged 1 commit into from
Sep 6, 2015

Conversation

istaslis
Copy link
Contributor

@istaslis istaslis commented Sep 3, 2015

Dummy parameters should be added in the top selector file in order to be accessible from confdb.
This PR doesn't change anything in the reconstruction and is a pure python fix.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

A new Pull Request was created by @istaslis (Stas Lisniak) for CMSSW_7_5_X.

Added dummy parameters to HIMultiTrackSelector

It involves the following packages:

RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @echapon, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 3, 2015

+1

For #11105 9d74e9f

Technical change to add dummy parameters to HIMultiTrackSelector. There should be no change in run-time behavior. #11106 is the 76X version of this PR, and it has already been approved by Reco.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-09-02-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Sep 6, 2015
Added dummy parameters to HIMultiTrackSelector
@davidlange6 davidlange6 merged commit 0cc5981 into cms-sw:CMSSW_7_5_X Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants