Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a 'kNoTypesStored' bug in DQMRootSource (74x) #11171

Merged
merged 1 commit into from
Sep 7, 2015
Merged

Fix a 'kNoTypesStored' bug in DQMRootSource (74x) #11171

merged 1 commit into from
Sep 7, 2015

Conversation

dmitrijus
Copy link
Contributor

Port of #11169

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 7, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_4_X.

Fix a 'kNoTypesStored' bug in DQMRootSource (74x)

It involves the following packages:

DQMServices/FwkIO

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 7, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor

deguio commented Sep 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

+1
Tested at: 3167b9e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11171/7928/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11171/7928/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 7, 2015
@cmsbuild
Merge pull request #11171 from dmitrijus/dqm_root_source_74x
2cd548e 
Fix a 'kNoTypesStored' bug in DQMRootSource (74x)
@cmsbuild cmsbuild merged commit 2cd548e into cms-sw:CMSSW_7_4_X Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitrijus @cmsbuild @deguio @davidlange6