Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ROOT5 checksums known to ROOT6 #11210

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 9, 2015

Some class checksums for ROOT5 have changed, causing build problems in CMSSW_7_4_ROOT5_X.
This PR simply makes the new ROOT5 checksums visible in the ROOT6 release, CMSSW_7_4_X.
PR #11211 will fix the build problems in 7_4_ROOT5_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Make ROOT5 checksums known to ROOT6

It involves the following packages:

DataFormats/PatCandidates
DataFormats/TauReco

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@cvuosalo
Copy link
Contributor

+1

For #11210 737f5f3

Small fix to make ROOT5 checksums known to ROOT6. There should be no change in run-time behavior.

Jenkins tests against baseline CMSSW_7_4_X_2015-09-08-2300 show no significant differences, as expected.

davidlange6 added a commit that referenced this pull request Sep 16, 2015
@davidlange6 davidlange6 merged commit 6122c50 into cms-sw:CMSSW_7_4_X Sep 16, 2015
@wmtan wmtan deleted the MakeROOT5ChecksumsKnownToROOT6 branch September 16, 2015 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants