Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning of pat::MET data format #11222

Merged

Conversation

mmarionncern
Copy link

Remove unused old format functions from the header file.

Do not affect any sequence nor physics.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_4_X.

Cleaning of pat::MET data format

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@gpetruc
Copy link
Contributor

gpetruc commented Sep 15, 2015

Was there any reason to rename uncorrectedPt to uncorPt (and the same for the other methods), thus breaking compatibility with existing analysis code calling them and existing documentation?

davidlange6 added a commit that referenced this pull request Sep 16, 2015
…xFormat

Cleaning of pat::MET data format
@davidlange6 davidlange6 merged commit c66dd73 into cms-sw:CMSSW_7_4_X Sep 16, 2015
@mmarionncern mmarionncern deleted the METCorUnc_75XbackportFor74X_FixFormat branch November 14, 2016 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants