Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for boosted top parameter setting. #1124

Merged
merged 1 commit into from
Oct 22, 2013

Conversation

rappoccio
Copy link
Contributor

Fixing bug where no configuration parameters were passed for a few boosted top algorithms, resulting in only default parameters being possible. Those affected :

-fastjet "native" implementation of the CMS top tagger (although we still use "our" version by default)
-fastjet "native" implementation of JHU top tagger
-"Our" implementation of the HEP Top Tagger
-fastjet "native" implementation of N-subjettiness rest frame tagger.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_0_X.

Bug fix for boosted top parameter setting.

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Oct 22, 2013

+1
tested a1b63fd
No difference seen in reco

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 22, 2013
Reco bugfix -- Bug fix for boosted top parameter setting.
@ktf ktf merged commit 0acdb97 into cms-sw:CMSSW_7_0_X Oct 22, 2013
@rappoccio rappoccio deleted the BoostedTopAddParameters branch January 7, 2014 18:28
gpetruc pushed a commit to gpetruc/cmssw that referenced this pull request May 24, 2023
Ensure cluster ecal_eta/phi are set when not running CombinedCaloLinker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants